-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable docs IA update redirects for zh-hans site #434
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Prerequisites checklist
What is the purpose of this pull request?
After merging eslint/zh-hans.docs.eslint.org#95, which included URL changes from eslint/eslint#16665, we forgot to enable redirects (#388) for the zh-hans site.
What changes did you make? (Give an overview)
Updated redirects template to enable docs IA update redirects for the zh-hans site.
Redirects from
source-code
todevelopment-environment
(#409) are still specific for the en site only because the change (eslint/eslint#16780) was merged for v8.33.0, while the zh-hans docs site is currently synced with 8.32.0.Related Issues
No.
Is there anything you'd like reviewers to focus on?
Please double check how this change affects the
_site/_redirects
file: